Skip to content

Testing reviewer checklist actions #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2025
Merged

Testing reviewer checklist actions #27

merged 3 commits into from
Sep 8, 2025

Conversation

@RayStick
Copy link
Member

@RayStick RayStick commented Sep 8, 2025 •
edited
Loading

Summary and intended behaviour

This PR is to test the new reviewer checklist action and see if it works (already in main).

The intended behaviour is

  1. Person A adds themselves as a reviewer. As they are the first reviewer, they get main_rev_checklist.md pasted to them in a comment
  2. Person B adds themselves as a reviewer. As they are not the first, they get rev_checklist.md pasted to them in a comment
  3. Any more reviewers to add themselves should be treated the same as Person B

Other context

  • If someone else assigns a person as a reviewer, nothing will trigger
  • The author of the PR gets automatically given the assignee label

Actions needed

@smoia can you please add yourself as a reviewer to this PR

@m-miedema can you please add yourself as a reviewer to this PR (but only after Stef has!)

@RayStick
Revise reviewer checklist section title
f685ec3 
Updated section title for clarity and consistency.
@RayStick RayStick changed the title Revise reviewer checklist section title Testing reviewer checklist actions Sep 8, 2025
@github-actions github-actions bot added the Documentation This issue or PR is about the documentation label Sep 8, 2025
@smoia smoia self-requested a review September 8, 2025 12:33
@github-actions
Copy link

github-actions bot commented Sep 8, 2025

Hello @smoia!

You've been assigned to this PR, which means that you've been nominated Main Reviewer! Lucky you!

As a Main Reviewer, you are slightly more responsible for the quality of this PR than your fellow Reviewers. If you have any doubt, check this section on reviewing and this section on being the Main Reviewer of the documents.

Before merging this PR, please check that:

  • The PR passes all the CircleCI/Azure tests.
  • The content respects the Style Guide.
  • If the PR contains documentation, your local build is right.
  • The PR and the reviews are harmonious with the rest of the repository, especially that they don't introduce repetitions
  • The title of the PR is clear enough to describe a release content.
  • The labels are correct - and they will (or won't) trigger the correct auto release.
  • The PR received the amount of approvals necessaries to be merged.

If the PR contains code changes:

  • Content and changes are adequately documented in the docstrings.
  • User documentation is being updated accordingly - or a related issue has been opened.
  • The adequate tests have been added/updated - or a related issue has been opened if coverage doesn't drop below 90%.

After you merged this PR, please check that:

  • The Author(s) and Reviewers contributions have been updated in the README.
  • The updates (in code, tests and documentation) have appened correctly.
  • If they had to, the tag was created, the release was cut, and the pypi version got updated.

Thank you!

@smoia
Copy link
Member

smoia commented Sep 8, 2025

@m-miedema your turn!

@smoia smoia requested a review from m-miedema September 8, 2025 12:34
@RayStick RayStick removed the request for review from m-miedema September 8, 2025 12:47
@RayStick RayStick requested review from m-miedema and removed request for m-miedema September 8, 2025 13:03
@RayStick RayStick requested a review from m-miedema September 8, 2025 13:11
@github-actions
Copy link

github-actions bot commented Sep 8, 2025

Hello @m-miedema!

You've been assigned to this PR, which means that you've been nominated Main Reviewer! Lucky you!

As a Main Reviewer, you are slightly more responsible for the quality of this PR than your fellow Reviewers. If you have any doubt, check this section on reviewing and this section on being the Main Reviewer of the documents.

Before merging this PR, please check that:

  • The PR passes all the CircleCI/Azure tests.
  • The content respects the Style Guide.
  • If the PR contains documentation, your local build is right.
  • The PR and the reviews are harmonious with the rest of the repository, especially that they don't introduce repetitions
  • The title of the PR is clear enough to describe a release content.
  • The labels are correct - and they will (or won't) trigger the correct auto release.
  • The PR received the amount of approvals necessaries to be merged.

If the PR contains code changes:

  • Content and changes are adequately documented in the docstrings.
  • User documentation is being updated accordingly - or a related issue has been opened.
  • The adequate tests have been added/updated - or a related issue has been opened if coverage doesn't drop below 90%.

After you merged this PR, please check that:

  • The Author(s) and Reviewers contributions have been updated in the README.
  • The updates (in code, tests and documentation) have appened correctly.
  • If they had to, the tag was created, the release was cut, and the pypi version got updated.

Thank you!

@RayStick RayStick merged commit 5e5e538 into master Sep 8, 2025
2 checks passed
@RayStick RayStick deleted the testing branch September 8, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoia smoia Awaiting requested review from smoia

@m-miedema m-miedema Awaiting requested review from m-miedema

Assignees

@RayStick RayStick

Labels

Documentation This issue or PR is about the documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RayStick @smoia